Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move vault setup into repo so all ci logic is in the repo #42642

Merged
merged 5 commits into from Aug 6, 2019
Merged

move vault setup into repo so all ci logic is in the repo #42642

merged 5 commits into from Aug 6, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Aug 5, 2019

In order to improve the windows/linux compatibility, this moves the vault interactions from the CI config files into the repo.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.0.2 v7.1.2 v7.4.0 v7.2.2 v7.3.1 v6.8.3 labels Aug 5, 2019
@spalger spalger requested a review from a team as a code owner August 5, 2019 21:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

tylersmalley
tylersmalley approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I assume we're getting this in prior to setting VAULT_SECRET_ID for the job.

@spalger
Copy link
Contributor Author

spalger commented Aug 5, 2019

Yeah, this logic is already executing on CI before this script runs, which is why VAULT_SECRET_ID is unset by the time it runs. Once this is merged I'll be testing in a local Jenkins to make sure that the new secrets will be initialized appropriately before removing the current script in CI config.

@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 9ddbd84 into elastic:master Aug 6, 2019
This was referenced Aug 6, 2019
Merged
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 6, 2019
move vault setup into repo so all ci logic is in the repo (elastic#42642
d6ec701 
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 6, 2019
move vault setup into repo so all ci logic is in the repo (elastic#42642
3d9a3e5 
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR
@spalger spalger mentioned this pull request Aug 6, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 6, 2019
move vault setup into repo so all ci logic is in the repo (elastic#42642
89777b3 
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR
@spalger spalger mentioned this pull request Aug 6, 2019
Closed
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 6, 2019
move vault setup into repo so all ci logic is in the repo (elastic#42642
d123c2b 
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

# Conflicts:
#	.ci/run.sh
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 6, 2019
move vault setup into repo so all ci logic is in the repo (elastic#42642
d941562 
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

# Conflicts:
#	.ci/run.sh
This was referenced Aug 6, 2019
Closed
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Aug 6, 2019
move vault setup into repo so all ci logic is in the repo (elastic#42642
f0be461 
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

# Conflicts:
#	.ci/run.sh
@spalger
Copy link
Contributor Author

spalger commented Aug 6, 2019 •
edited

7.x/7.4: 888b575
7.3: 0740aa3
7.2: 17b6727
6.8: 2eff7f9

spalger pushed a commit that referenced this pull request Aug 6, 2019
move vault setup into repo so all ci logic is in the repo (#42642) (#…
2eff7f9 
…42654)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

# Conflicts:
#	.ci/run.sh
@spalger spalger deleted the implement/local-vault-interactions branch August 6, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v6.8.3 v7.2.2 v7.3.1 v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spalger @elasticmachine @tylersmalley